-
-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppVeyor: prevent unnecessary builds #2888
Conversation
this should not trigger a appveyor build
this should not trigger a appveyor build
this should not trigger a appveyor build
this should not trigger a appveyor build
this should not trigger a appveyor build
Tested and working with changes to these files: All of these correctly didn't trigger AppVeyor builds! 👍 Cancelled all the pending macOS builds on travis. Linux builds fine for sure and we don't want to wait several hours for all of these to finish. 😆 |
There seems to be a problem with the GitHub status check and how it expects results for This looks to be a very minor issue, given the benefit. |
This seems to work: the last build has been skipped. |
Linking AppVeyor support ticket and discussion: appveyor/ci#1848 |
Short roundup of the initial problem
AppVeyor CI always started builds, also on completely unrelated changes.
What will change with this Pull Request?
Results in faster check marks for quicker merging. Also, important builds don't queue up and have to wait for such unrelated build to finish.
For example, travis is building this change to a appveyor config file, a total waste and delay!
Am I correct, that we don't want AppVeyor to build changes made in the webclient as well?
Did I miss anything?
This also removes theqt5
extension for the windows builds. We don't use such a tag for our macOS and Linux builds.Sadly this is needed as of now:
Cockatrice/cockatrice/src/releasechannel.cpp
Lines 59 to 68 in ff6b0f8
We need a workaround for this to finally remove it in future versions. At best before releasing a new version. Just add an additional check for
-x86_64
and-x86
withoutqt5
for the transition period?