Allow non-db cards to be moved around #2960
Conversation
|
I like that. What do you think about having the card name in red in the decklist for such cards?
|
|
I like the idea of painting the background with a css style (so it's themable) defaulting to red when we don't have the card. That can be a separate PR |
cockatrice/src/decklistmodel.cpp
Outdated
| @@ -264,11 +264,44 @@ QModelIndex DeckListModel::findCard(const QString &cardName, const QString &zone | |||
| return nodeToIndex(cardNode); | |||
| } | |||
|
|
|||
| QModelIndex DeckListModel::addCard(const QString &cardName, const QString &zoneName) | |||
| QModelIndex DeckListModel::addCard(const QString &cardName, const QString &zoneName, bool anAddAnyway) | |||
There was a problem hiding this comment.
what's the an in anAddAnyway?
Maybe rename to addIfMissingFromDb?
There was a problem hiding this comment.
an = argument variable, n = integer... should be a b = boolean. Will fix this to be
abAddAnyway
There was a problem hiding this comment.
We don't use hungarian notation, please don't do that. We can tell it's an argument because it's in the argument list and we can tell it's a boolean because it's labelled bool.
|
I guess we are good here then after the var rename @Daenyth ? |
Fixes #2954
Before we could not move cards around if they weren't in the DB b/c if the card was not in the db, the program would discard the entry. There is now an overload variable that tells the program to pretend it's in the database with default values and continue as directed.
Load from Clipboard:
Highlight the row and press "S":
