Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

card filter: alphabetical ordering for keywords #2987

Merged
merged 7 commits into from
Jan 10, 2018
Merged

Conversation

tooomm
Copy link
Member

@tooomm tooomm commented Jan 2, 2018

Short roundup of the initial problem

Keywords used to be unordered.
Because of the missing logical structure it was difficult to quickly find the needed filter.

What will change with this Pull Request?

  • Display filter keywords in alphabetical order
  • Filter logic is ordered in the same way in the code now, too

Screenshots

  • before:
    untitled1

  • after:
    untitled2

@Nightfirecat
Copy link

Can these be sorted without reordering the cases of CardFilter::attrName in cardfilter.cpp? I don't mind them being alphabetically ordered in the source as well, but I'm also generally in favor of sorting with a .sort() call instead of doing it by hand—that way, future changes don't have to rigorously follow the same sorting, but would be automatically sorted.

@ZeldaZach
Copy link
Member

@Nightfirecat I fully agree. This complicated change logs for no reason

@tooomm
Copy link
Member Author

tooomm commented Jan 3, 2018

Only the few changed lines in cardfilter.h are the crucial ones for the displaying purpose here. I updated the PR accordingly.

If somebody comes up with a smart self-sorting solution and opens a PR, this can be closed for sure. 👍

Copy link
Member

@ZeldaZach ZeldaZach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

@ZeldaZach ZeldaZach merged commit e6e6932 into master Jan 10, 2018
@ZeldaZach ZeldaZach deleted the tooomm-alph_filter branch January 10, 2018 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants