Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

token creation context menu improvements #2999

Merged
merged 3 commits into from
Jan 10, 2018
Merged

token creation context menu improvements #2999

merged 3 commits into from
Jan 10, 2018

Conversation

tooomm
Copy link
Member

@tooomm tooomm commented Jan 8, 2018 •
edited
Loading

What will change with this Pull Request?

  • better visual display and separation of card names that other cards get attached to
  • make quantity of tokens more clear, the quantity digit and token strength digit visually merged easily

Screenshots

  • before:
    abbey-old
    alarm-old
    old

  • after:
    abbey
    alarm
    new
    morph

Note that single numbered tokens and flexible quantity "X" won't change and aren't affected.
Also, nothing changes for translators.

Please double check code context and logic.

ZeldaZach
ZeldaZach approved these changes Jan 10, 2018
View reviewed changes
Copy link
Member

@ZeldaZach ZeldaZach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@ZeldaZach ZeldaZach merged commit 7efab80 into master Jan 10, 2018
@tooomm tooomm deleted the tooomm-token_numbering branch January 10, 2018 18:48
@Psithief
Copy link
Contributor

Perhaps not x but ×?

@tooomm
Copy link
Member Author

tooomm commented Feb 28, 2018

You suggest to exchange the lower case "times" x like this?
Token: 3x 2/2 Zombie --> Token: 3× 2/2 Zombie

Token: 2x 1/1 Soldier --> Token: 2× 1/1 Soldier


If a card has both, a fixed and a variable quantity:

Token: 3× 2/2 Zombie
Token: X 2/2 Zombie

What do others think?

@ZeldaZach
Copy link
Member

I’m happy with how it is. That seems a bit frivolous

@Psithief
Copy link
Contributor

Psithief commented Mar 3, 2018

Frivolous to an English speaker, perhaps!
But you have Unicode support by default, why not use it where it's appropriate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeldaZach ZeldaZach ZeldaZach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tooomm @Psithief @ZeldaZach