Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

card filter: add clear button and placeholder text #3003

Merged
merged 3 commits into from
Jan 11, 2018

Conversation

tooomm
Copy link
Member

@tooomm tooomm commented Jan 10, 2018

What will change with this Pull Request?

Screenshots

It now looks like this:

  • Before you start typing you see the placeholder text:
    before typing
  • During typing it disapears, but you'll see a clear button instead to delete all line at once:
    during typing

@tooomm tooomm changed the title card search: add clear button and placeholder text card filter: add clear button and placeholder text Jan 10, 2018
Copy link
Member

@ZeldaZach ZeldaZach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Tabs->Spaces
  2. Remove the #if guards for the clearButtonEnabled. We build exclusively on QT5 nowadays and we do not have to worry about that

edit = new QLineEdit;
edit->setObjectName("edit");
edit->setPlaceholderText(tr("Type your filter here"));
#if QT_VERSION >= 0x050200
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We build above 5.0.2, so these guards should be removed at this time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mirrored them from another place in the app.
Will remove both then 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postponed, see #3005

@tooomm tooomm dismissed ZeldaZach’s stale review January 11, 2018 12:28
  1. is addressed // 2. is not yet possible, see #3005
Copy link
Member

@ZeldaZach ZeldaZach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

@ZeldaZach ZeldaZach merged commit cc822dd into master Jan 11, 2018
@ZeldaZach ZeldaZach deleted the tooomm-card_filter branch January 11, 2018 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants