-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
card filter: add clear button and placeholder text #3003
Conversation
also 4 spaces to tabs
also 4 spaces to tabs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Tabs->Spaces
- Remove the #if guards for the clearButtonEnabled. We build exclusively on QT5 nowadays and we do not have to worry about that
cockatrice/src/filterbuilder.cpp
Outdated
edit = new QLineEdit; | ||
edit->setObjectName("edit"); | ||
edit->setPlaceholderText(tr("Type your filter here")); | ||
#if QT_VERSION >= 0x050200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We build above 5.0.2, so these guards should be removed at this time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mirrored them from another place in the app.
Will remove both then 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
postponed, see #3005
- is addressed // 2. is not yet possible, see #3005
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good
What will change with this Pull Request?
Screenshots
It now looks like this: