Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add No annotations export option w/ shortcut #3013

Merged
merged 3 commits into from
Jan 19, 2018
Merged

Add No annotations export option w/ shortcut #3013

merged 3 commits into from
Jan 19, 2018

Conversation

ZeldaZach
Copy link
Member

This allows users to export decks to the clipboard without all the annotations. Useful when they want to export to different places that do not accept our annotations.

screenshot 2018-01-13 01 51 54

screenshot 2018-01-13 01 52 05

Annotated:

// 5 Maindeck
// 4 Creature
1 Academy Researchers
1 Sleeper Agent
1 Goblin Rock Sled
1 Scoria Wurm

// 1 Land
1 Forbidding Watchtower

// 4 Sideboard
// 4 Creature
SB: 1 Scoria Wurm
SB: 2 Sisters of the Flame
SB: 1 Psionic Entity

Not Annotated:

1 Academy Researchers
1 Sleeper Agent
1 Goblin Rock Sled
1 Scoria Wurm
1 Forbidding Watchtower

1 Scoria Wurm
2 Sisters of the Flame
1 Psionic Entity

Daenyth
Daenyth approved these changes Jan 17, 2018
View reviewed changes
Copy link
Member

@Daenyth Daenyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. In the future, separating large formatting changes to their own commit will make review easier

cockatrice/src/sequenceEdit/sequenceedit.cpp Outdated
{
QKeyEvent * keyEvent = (QKeyEvent *) event;
auto *keyEvent = (QKeyEvent *) event;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace with cpp-style cast? I think this is a reinterpret_cast ?

@ZeldaZach ZeldaZach merged commit ebec30d into Cockatrice:master Jan 19, 2018
@ZeldaZach ZeldaZach deleted the add_options branch January 19, 2018 00:25
@tooomm tooomm mentioned this pull request Jan 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daenyth Daenyth Daenyth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ZeldaZach @Daenyth