Split card handling added to cmc filter #3090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daenyth
approved these changes
Feb 7, 2018
|
Thanks @Daenyth ! |
ZeldaZach
reviewed
Feb 7, 2018
cockatrice/src/filtertree.cpp
Outdated
| // if conversion failed, check for the "//" separator used in split cards | ||
| if (!convertSuccess) { | ||
| int cmcSum = 0; | ||
| foreach (QString cmc, info->getCmc().split("//")) { |
There was a problem hiding this comment.
can you change this to for (QString cmc : info->getCMC().split("//")) { ? I'm trying to remove the foreach from the codebase as it's not proper C++
There was a problem hiding this comment.
We should see if we can add a custom lint rule to codacy
Good that you mention something like that, I guess we were not aware of that as of now. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Short roundup of the initial problem
CMC filter didn't work on split cards in the deck builder
Screenshots