Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change vcredist install option from "/quiet" to "/passive" #3175

Merged
merged 2 commits into from
Apr 7, 2018

Conversation

tooomm
Copy link
Member

@tooomm tooomm commented Apr 7, 2018

Related Ticket(s)

Short roundup of the initial problem

Some users reported problems with the install process. Like it got stuck sometimes or didn't trigger.
Due to the \quiet option there was no hint or error message presented to the user.

What will change with this Pull Request?

  • use \passive instead

(from #3169 (comment))

It pops up a dialog which immediately closes again if it's already installed...
Otherwise it'll show you a dialog with the install progress which automatically closes after it's done.
In @msi1289's case he probably would have seen some kind of error there without the need to check some logs which are placed in the TEMP folder regarding your last screen.

I also tried to remove the \quiet option without substitution, but the result was less appealing as described in #3169 (comment).

Thanks for pointing in the right direction @ctrlaltca 👍

Screenshots

vcinstall

Copy link
Contributor

@ctrlaltca ctrlaltca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@ZeldaZach ZeldaZach merged commit 42d15c3 into master Apr 7, 2018
@tooomm tooomm deleted the tooomm-loud branch April 7, 2018 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants