Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server site added to connect window #3190

Conversation

Vafthrudnir
Copy link
Contributor

@Vafthrudnir Vafthrudnir commented Apr 10, 2018

Related Ticket(s)

What will change with this Pull Request?

The sites set in the public servers JSON are saved in the user's settings and showed as links on the connect window.

Screenshots

With official servers after a refresh:
image
With custom servers:
image

Copy link
Member

@ZeldaZach ZeldaZach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I like it a lot. Users will have to refresh their current servers for this to take affect, but no big deal

@ZeldaZach ZeldaZach merged commit cc2a0fa into Cockatrice:master Apr 10, 2018
@Vafthrudnir Vafthrudnir deleted the feature/2906_contact_hint_on_connect_window branch April 11, 2018 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants