datetime display fixed for OSs with non-English localization

[Vafthrudnir]

Related Ticket(s)

• Fixes Spoiler pop-up broken on windows #3140

Short roundup of the initial problem

Time of last spoiler update was not displayed on OS-s where the localization was set to other than English.

QDateTime::fromString() method tries to parse the given string based on the OS's default localization setting, which caused an invalid date, since the string was in English. Setting QLocale default to English and using it to parse dates instead of QDateTime solved the problem.

Screenshots

[Daenyth]

👍

[Vafthrudnir]

Added the localization settings and cockatrice language to the logs. Localization is only checked on startup, and language is logged with every change.

Client Version: 2.5.0-custom(cc2a0fa) (2018-04-10)
Client Operating System: Windows 10
Build Architecture: 32-bit
Qt Version: 5.7.1
System Locale: hu_HU
Theme name not set, setting default value
Theme changed: "Default"
Sounds theme name not set, setting default value
SoundEngine: disabling sound
Sound theme changed: "Default"
SoundEngine: disabling sound
Language changed:  "en@pirate"
main(): starting main program

[tooomm]

Client Version: 2.5.0-custom(e00467c) (2018-04-16)
Client Operating System: Windows 10 (10.0)
Build Architecture: 64-bit
Qt Version: 5.9.4
System Locale: de_DE
Theme changed: "Magic The Gathering"
SoundEngine: disabling sound
Sound theme changed: "Default"
SoundEngine: disabling sound
Language changed:  "en"
main(): starting main program
main(): MainWindow constructor finished
CardDatabase::loadCardDatabases start
main(): ui.show() finished

There is a double space between Language changed: and "en", same in your example @Vafthrudnir.

Otherwise it works for me and the date is correctly shown again! Awesome 👍