macOS: fix qt plugin installation #3216
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short roundup of the initial problem
During the "install" step, cmake installs all the Qt plugins required at runtime by the applications.
Each application needs a different set of plugins (eg. cockatrice needs to be able to load different image formats, while servatrice doesn't but needs to be able to connect to a mysql server), and installing them all means to waste space and time.
With recent Qt versions, the regexp we used to filter only the needed plugins doesn't work anymore as expected, and was basically installing the whole
plugins/
directory (336MB) on each application.The current cockatrice release is still using Qt 5.5, so is not affected by this problem. This of this PR as some preliminary work to be able to update Qt on macOS in the future.
What will change with this Pull Request?
make install
step under macOS for debug builds, so that we can see what libraries/frameworks/plugins are picked up by cmake;Screenshots
not really a screenshot, but here's a log including the
make install
details showing that not all the plugins are being installed:https://travis-ci.org/ctrlaltca/Cockatrice/jobs/372043082#L7642