braces are only left for split cards #3217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thought this was a feature. Whoops haha |
|
Well, the previous modification was only meant to put braces around split mana costs, but if you think it's better I can change it back to that version. The code must be modified either way, because in that case it's quite useless to look for split costs and then do nothing special with them. |
tooomm
requested changes
May 2, 2018
|
Thanks for noticing that @tooomm! Fixed it in the previous commit. |
|
|
|
Have you run oracle again? This same version show up as this at me: |
tooomm
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short roundup of the initial problem
Due to a mistake in #3108 all mana costs are shown in braces instead of only split costs. This PR fixes that.
Screenshots