Extract the xml parser from carddatabase #3223
Conversation
| { | ||
| public: | ||
| virtual ~ICardDatabaseParser() {} | ||
| virtual bool getCanParseFile(const QString &name, QIODevice &device) = 0; |
There was a problem hiding this comment.
I want a pure virtual function in order to make the class abstract (non-instanceable).
As far as I understand, with = delete the method is not callable, but the class can still be instanced.
There was a problem hiding this comment.
https://stackoverflow.com/questions/24958270/why-cant-i-declare-a-pure-virtual-function-with-delete Yeah you're right. Didn't realize we could create a fully abstract class in C++ :D
There was a problem hiding this comment.
Yep, in any other language i'd use an interface. In C++ you need some trickery to achieve the same result.
|
You'll want to run the |
cockatrice/src/carddatabase.h
Outdated
| @@ -398,11 +397,11 @@ class CardDatabase : public QObject | |||
|
|
|||
| LoadStatus loadStatus; | |||
|
|
|||
| /* | |||
| * The available card database parsers | |||
There was a problem hiding this comment.
👎 IMO we should avoid "what is this code" style comments unless it's very hard. In this case naming the variable availableParsers would be enough.
| public: | ||
| CockatriceXml3Parser() {}; | ||
| ~CockatriceXml3Parser() {}; | ||
| CockatriceXml3Parser(){}; |
Related Ticket(s)
Short roundup of the initial problem
See #3201
What will change with this Pull Request?
The xml parser has been extracted from the card database.
The card database now supports querying multiple parsers; by now the only parser available is the "old" xml file parser.
There should be no user-noticeable difference in card parsing, loading or anything else.