Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: more cleanup #3336

Merged
merged 22 commits into from
Aug 27, 2018
Merged

travis: more cleanup #3336

merged 22 commits into from
Aug 27, 2018

Conversation

tooomm
Copy link
Member

@tooomm tooomm commented Jul 18, 2018

Short roundup of the initial problem

Unneeded package installs listed in travis.yml

What will change with this Pull Request?

I tried to remove the other apt installs which should be already available in the Xenial image regarding this list: https://packages.ubuntu.com/xenial/allpackages (long load time!)
But it didn't work out. 馃槂

Screenshots

job names

@tooomm tooomm requested a review from ctrlaltca July 18, 2018 22:30
@ctrlaltca
Copy link
Contributor

If clang-format is already available, you can also remove the lines used to import the apt source for the llvm repository: https://github.com/Cockatrice/Cockatrice/pull/3336/files#diff-354f30a63fb0907d4ad57269548329e3R36
clang-format is a bit picky, since different versions can need different config files and different report errors, so you happen to know what version in installed? Ubuntu should have 6.0-41~exp4 installed by default

@tooomm
Copy link
Member Author

tooomm commented Aug 2, 2018

clang-format is a bit picky, since different versions can need different config files and different report errors, so you happen to know what version in installed? Ubuntu should have 6.0-41~exp4 installed by default

clang 5.0.0 is installed (see here), so it's clang-format 5.0.0, too:
https://travis-ci.org/Cockatrice/Cockatrice/jobs/411445789#L2101

I guess you are talking about a newer Ubuntu than the 16.04 Travis still uses. ;P

@ctrlaltca
Copy link
Contributor

Oh, you are right, i always forget how outdated the travis arch is.

@tooomm
Copy link
Member Author

tooomm commented Aug 27, 2018

@ctrlaltca Can you revisit and merge this PR, please?

I want no other CI stuff to lie around before looking into further changes.

@ctrlaltca ctrlaltca merged commit 135c02e into master Aug 27, 2018
@tooomm tooomm deleted the tooomm_ci branch August 27, 2018 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants