Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updater: remove check for now unused beta file endings #3338

Merged
merged 1 commit into from
Aug 2, 2018

Conversation

tooomm
Copy link
Member

@tooomm tooomm commented Jul 20, 2018

Related Ticket(s)

Short roundup of the initial problem

I went forward with my unanswered assumptions from #3083 as that's how I understand it:

File names are now always:

 Win (64bit) --> filename-win64.exe
 Win (32bit) --> filename-win32.exe
 macOS --> filename.dmg
 Ubuntu --> filename.deb

(in comparison to stable releases, filename part for betas only has a -beta or -beta.X tag attached)

So there is no need to check for x86 and x86_64 any longer!

Actually, is this betaEnd and exeBetaName needed alltogether?

We don't use such a pattern like -x86_64_qt5 for any releases anymore.
Don't we differentiate via the download urls between stable and beta?

What will change with this Pull Request?

  • remove unused beta naming mentions

@tooomm tooomm changed the title updater: remove check for unused beta file endings updater: remove check for former beta file endings Jul 21, 2018
@tooomm tooomm changed the title updater: remove check for former beta file endings updater: remove check for now unused beta file endings Jul 25, 2018
@ctrlaltca
Copy link
Contributor

Looks like this is fine to merge, since the only affected users are those on the "beta" release channel that didn't upgrade since more than one year.

@ctrlaltca ctrlaltca merged commit f1eab4e into master Aug 2, 2018
@tooomm tooomm deleted the tooomm-updater branch August 2, 2018 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants