Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI dialog tweaks: filter + create game(s) #3351

Merged
merged 21 commits into from
Jul 25, 2018
Merged

UI dialog tweaks: filter + create game(s) #3351

merged 21 commits into from
Jul 25, 2018

Conversation

tooomm
Copy link
Member

@tooomm tooomm commented Jul 24, 2018

Short roundup of the initial problem

Dialogs looked a bit weird and misaligned.

What will change with this Pull Request?

  • add group boxes to both dialogs for general information
  • create game: move remember check box very visible to the bottom
  • create game: swap game type selection with spectator box to have all important options on the left

Screenshots

  • Filter games before:
    before2

  • Filter games after:
    after-new2

  • Create game before:
    before

  • Create game after:
    after-new

@ctrlaltca
Copy link
Contributor

ctrlaltca commented Jul 24, 2018

Imho:

  • Filter games looks better before:
    schermata 2018-07-24 alle 17 24 52

  • Create game looks a bit better after, especially for the "remember settings" move

@tooomm
Copy link
Member Author

tooomm commented Jul 24, 2018

You are right, Filter games is a bit off. I didn't realized that... will take a look and try to fix that.

The little additional gap shouldn't be there:
after2

@tooomm
Copy link
Member Author

tooomm commented Jul 24, 2018

Fixed @ctrlaltca

after-new2

@ctrlaltca
Copy link
Contributor

Looks better now! 👍

@ctrlaltca ctrlaltca merged commit 451e187 into master Jul 25, 2018
@tooomm tooomm deleted the tooomm-spec_box branch July 25, 2018 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants