Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable using a shortcut for playing the top card of the library face down (fixed) #3388

Conversation

leestran1995
Copy link
Contributor

This pull request was made because the one I made before was branched off of the wrong branch

Related Ticket(s)

Short roundup of the initial problem

Unable to use/create a shortcut for moving a card from the top of the library to the play area faced down

What will change with this Pull Request?

  • enabled using and setting a shortcut to do the aforementioned action
  • set a default shortcut for the aforementioned action

Screenshots

image
image

Copy link
Member

@Daenyth Daenyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires an addition to the context menu for deck.

Start looking around tab_game or maybe gamescene?

@leestran1995
Copy link
Contributor Author

@Daenyth What do you mean by context menu for deck?

@ZeldaZach
Copy link
Member

I disagree with the shortcut selection. Since CTRL+Q can kill the program.

@leestran1995
Copy link
Contributor Author

leestran1995 commented Sep 5, 2018

@ZeldaZach The default is actually Ctrl+Shift+E, I just changed it locally to what's pictured to make sure that it was changeable. Sorry for being unclear about that!

@ctrlaltca
Copy link
Contributor

@Daenyth the action is already available in the library menu, only the shortcut key was missing.

@Daenyth
Copy link
Member

Daenyth commented Sep 6, 2018

action is already available in the library menu, only the shortcut key was missing.

In that case disregard me!

@ctrlaltca ctrlaltca merged commit 70005a6 into Cockatrice:master Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants