Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blank line between comments issue #3407

Merged
merged 2 commits into from
Oct 8, 2018

Conversation

dane-johnson
Copy link
Contributor

Related Ticket(s)

NA

Short roundup of the initial problem

If there existed a blank line in between comments before the first card, all cards were interpreted as sideboard. (This is the way deckstats.net exports cards decks with no sideboard).

What will change with this Pull Request?

  • Sideboard will only begin after one mainline card and a blank space
  • Test case added to prevent regression

Copy link
Member

@Daenyth Daenyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for adding a test. Our coverage is embarrassing, so this helps a lot :)

Copy link
Member

@ZeldaZach ZeldaZach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha nice :)

@ZeldaZach ZeldaZach merged commit bc2cb59 into Cockatrice:master Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants