Unconcede

[basicer]

Short roundup of the initial problem

• In a multiplayer game, if a player concedes but wants to reenter the game, all the remaining players in the game must also concede, restart the match, and then get their cards back how they were.
• When playing non-magic games like poker, a player can concede to sit out for a few hands, and then unconcede to resume playing.

What will change with this Pull Request?

• Clicking concede when a player has already conceded will prompt them asking if they would like to rejoin the game.

[ebbit1q]

Testing this would require a test server, did you test this already?

[basicer]

Yeah I tested it.

I also have some patches to test it in offline mode by adding the buttons to the player menu.

[ctrlaltca]

It works, but it's not that different from actually quitting the game and re-joining, since your deck and zones contents will be reset to the initial state.
The nice part is that you can rejoin the game (and start over) without forcing other users to quit the game too, re-choose their decks, etc..
Two problems:

• the concede menu entry should probably be renamed from "concede" to "unconcede" after a player conceded the game;
• in a 2 player game, when you concede you get back to the deck/sideboard view. From there, you can click "concede" and the game will ask if you want to unconcede, but it won't do nothing. Maybe the menu entry should be disabled when game is not being played (in the deck/sideboard view).

[basicer]

the concede menu entry should probably be renamed from "concede" to "unconcede" after a player conceded the game;

True, this is nicer, but wasn't sure it was worth managing the state, especially since tab_game doesn't know much about the state of the player that happens to be localPlayer. At one point I had an extra menu item for Unconcede, but it seemed like a waste of space.

in a 2 player game, when you concede you get back to the deck/sideboard view. From there, you can click "concede" and the game will ask if you want to unconcede, but it won't do nothing. Maybe the menu entry should be disabled when game is not being played (in the deck/sideboard view).

This matches more or less what happens now. You get a concede button, and you can click it.. get the prompt.. and nothing happens. I guess ideally you'd remove the entire game menu minus "Leave Game" and "Game Information" during side-boarding.

[ZeldaZach]

Not a big fan of the term "unconceded" maybe "rejoined"?

[basicer]

I thought about rejoin, but that has some overlap with rejoining the room. I hate the term unconceded so Im down to change everything including the proto command names if you think rejoin is clear.

[ctrlaltca]

I'm good with merging this.
Some existing problem with the menu have been noticed when testing this PR, but being unrelated they can be fixed in a following PR.