Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make qt's dialogs "default button text" translatable; fix #3498 #3527

Merged
merged 1 commit into from
Jan 27, 2019

Conversation

ctrlaltca
Copy link
Contributor

Related Ticket(s)

Short roundup of the initial problem

Generic dialogs containing strings such as "OK", "Cancel", "Save", .. were not translatable.

What will change with this Pull Request?

The list of text used in Qt's generic dialog buttons have been added as translatable resources.

Copy link
Member

@ZeldaZach ZeldaZach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@ZeldaZach ZeldaZach merged commit c3d94a5 into Cockatrice:master Jan 27, 2019
@ctrlaltca ctrlaltca deleted the fix_translations branch March 8, 2019 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants