-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Counter expressions #3534
Counter expressions #3534
Conversation
6932941
to
e6d303b
Compare
Is it possible to reference the current value of the counter? |
e6d303b
to
bbbad61
Compare
Yup, the current value is x. |
0d98501
to
c965d86
Compare
- Take an expression when setting a counter
c965d86
to
9464221
Compare
Err? Why can't you middle mouse button on trackpad? isn't it triple tap everywhere? I can do this just fine..... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected. 👍
A few notes:
- I was in doubt about the maintainability of including en external library, but it seems like it compiles fine cross-os, and the inclusion of MIT licensed code in a GPL project is ok; the original code seems to be https://github.com/yhirose/cpp-peglib
- as a c64 guy the first expression I tried was x/0, and the result was -MAX_INT. Is the result expected to be 0, since it should be treated as an error?
- I'm not sure how needed trigonometric and other functions are, but since they are for free, they are fine.
On macs the "three finger tap" is tied to a useless "lookup" function. The shift+click addition can be quite useful there. |
Do we want to let the user know that he can do calculations? |
I suppose we could put it in the tips and tricks dialog. |
Haven't thought about that one :) That would go here: Do you want to include that in this PR as well? |
Should be included in the PR since it's such a big change. Re: tom's comment on new tip dialog |
Signed-off-by: Zach Halpern <ZaHalpern+github@gmail.com>
Added tip entry; also, fixed tip-of-the-day dialog image size calculation. |
Short roundup of the initial problem
What will change with this Pull Request?