Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default minumum player count for multi column layout to 4 #3535

Merged
merged 1 commit into from
Jan 30, 2019

Conversation

ebbit1q
Copy link
Member

@ebbit1q ebbit1q commented Jan 30, 2019

fixes #3533
does not change existing settings

Copy link
Contributor

@ctrlaltca ctrlaltca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Forcing the change on existing users would be too much.

@ctrlaltca ctrlaltca merged commit bb4ca4d into Cockatrice:master Jan 30, 2019
@ebbit1q ebbit1q deleted the mincolumnplayers branch January 30, 2019 14:37
@Insertcleverphrasehere
Copy link

Insertcleverphrasehere commented Jan 30, 2019

'forcing' wouldn't be accurate, they are free to change it back. But nothing will change unless we make a bump and shift everyone to multi column layout for 4. People will be free to change it back to 5 if they want, but if we want to create a unified system without lots of conflict, we need to update all the clients.

(If we don't then new players won't know why other people are piling stuff to the right because they don't know that a lot of other players will still be on non-multi column layout).

Perhaps a popup indicating what has changed and how to change it back if they don't like it might make it more palatable to update everyone's settings all at once?

@ZeldaZach
Copy link
Member

Seems like a lot of effort on our parts for a minimal change imo, but maybe we can use this as an abstract method to update settings on the fly (see the URLs I introduced that @ctrlaltca modified with the new XML format). We can inform the users "OLD" and "NEW" and they can choose to revert our change.

@ebbit1q
Copy link
Member Author

ebbit1q commented Jan 30, 2019

People don't like change, simply put.

@Insertcleverphrasehere
Copy link

Zach's suggestion sound's like it would work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi Column layout default should be 4, not 5.
4 participants