Client Websockets #3545
Merged
Client Websockets #3545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basicer
force-pushed
the
websocket
branch
3 times, most recently
from
eaaead6
to
35ad149
Compare
|
Could be a problem |
Signed-off-by: Zach Halpern <ZaHalpern+github@gmail.com>
ctrlaltca
requested changes
Feb 2, 2019
There was a problem hiding this comment.
Great addition!
By now the cmake script is considering Qt5::WebSockets an optional (not-mandatory) component, so we should add proper #ifdef QT_WEBSOCKETS_LIB guards everywhere this Qt framework is used.
Since Qt5::WebSockets is available since Qt 5.3 and we already require 5.5, you can also consider adding it to the required components in the main CMakeLists. This could eventually needs some fixes in the CI build scripts to add the required libraries.
- Remove QWEBSOCEKT_LIB guards - Only TCP on port 4747 - Fix peerName lookup
ctrlaltca
approved these changes
Feb 3, 2019
tooomm
added a commit
to Cockatrice/cockatrice.github.io
that referenced
this pull request
Feb 4, 2019
tooomm
added a commit
to Cockatrice/cockatrice.github.io
that referenced
this pull request
Feb 5, 2019
See Cockatrice/Cockatrice#3545 https://github.com/Cockatrice/Cockatrice/blob/master/cockatrice/src/handle_public_servers.cpp#L74 <br> I also deprecated dr4ft server as it has been down for quite a while and added some cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Short roundup of the initial problem
What will change with this Pull Request?