-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Click replay timeline to seek. #3570
Conversation
06a7116
to
e5e9ef5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work full bar length for "shorter" games but for long ones it cuts off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok, nice feature!
I couldn't test with a huge file though.
Works fine! I see you are basically restarting the replay from the beginning to the point where the user clicked. |
It only starts over if you seek backwards, but I agree the log should be cleared in that case. |
Signed-off-by: Zach Halpern <ZaHalpern+github@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Pushed some minor cleanup :)
Short roundup of the initial problem
You can't seek replays, so if you want to rewind, you have to start over and fast forward.
What will change with this Pull Request?
Clicking on the histogram seeks the replay to that position.