Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click replay timeline to seek. #3570

Merged
merged 4 commits into from
Feb 9, 2019
Merged

Conversation

basicer
Copy link
Member

@basicer basicer commented Feb 8, 2019

Short roundup of the initial problem

You can't seek replays, so if you want to rewind, you have to start over and fast forward.

What will change with this Pull Request?

Clicking on the histogram seeks the replay to that position.

@basicer basicer force-pushed the seek-reply branch 2 times, most recently from 06a7116 to e5e9ef5 Compare February 8, 2019 06:27
Copy link
Member

@ZeldaZach ZeldaZach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenshot 2019-02-08 01 53 15

Clicking up to this point, works as expected. Nice job! Clicking past that point, the entire bar goes blank. No concessions or anything, it's mid-game. Clicking freezes it and you need to click back in the "safe" area to continue.

@ZeldaZach
Copy link
Member

Seems to work full bar length for "shorter" games but for long ones it cuts off

Copy link
Member

@tooomm tooomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, nice feature!

I couldn't test with a huge file though.

@ctrlaltca
Copy link
Contributor

ctrlaltca commented Feb 8, 2019

Works fine! I see you are basically restarting the replay from the beginning to the point where the user clicked.
In the message log the new events are added to the ones already present, maybe it would be better to clean the message log every time the user clicks on the histogram and the whole history gets replayed?

@basicer
Copy link
Member Author

basicer commented Feb 8, 2019

Works fine! I see you are basically restarting the replay from the beginning to the point where the user clicked.
In the message log the new events are added to the ones already present, maybe it would be better to clean the message log every time the user clicks on the histogram and the whole history gets replayed?

It only starts over if you seek backwards, but I agree the log should be cleared in that case.

basicer and others added 2 commits February 8, 2019 12:08
Signed-off-by: Zach Halpern <ZaHalpern+github@gmail.com>
Copy link
Member

@ZeldaZach ZeldaZach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Pushed some minor cleanup :)

@ZeldaZach ZeldaZach merged commit 612edae into Cockatrice:master Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants