Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unbalanced save() restore() in cards painter. #3571

Merged
merged 2 commits into from
Feb 8, 2019

Conversation

basicer
Copy link
Member

@basicer basicer commented Feb 8, 2019

Short roundup of the initial problem

There are thousands of spam lines in console saying QPainter::end: Painter ended with 2 saved states

What will change with this Pull Request?

No more of that.

@tooomm
Copy link
Member

tooomm commented Feb 8, 2019

Hmm, the debug log dialog windows seems to be negatively effected...
Does it still works for you @basicer ?

@ctrlaltca
Copy link
Contributor

@tooomm i'm afraid the mess in the debug log is caused by #3567

@tooomm
Copy link
Member

tooomm commented Feb 8, 2019

I guess it is ok to fix it up here?

Or do you want to open a separate PR and update this pr from master? @ctrlaltca

@ctrlaltca
Copy link
Contributor

Or do you want to open a separate PR and update this pr from master? @ctrlaltca

Done, #3572

Copy link
Member

@tooomm tooomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the result. Finally these messages are gone. 😍

@ctrlaltca ctrlaltca merged commit b065ada into Cockatrice:master Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants