Updater for websockets #3581
Merged
Updater for websockets #3581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basicer
force-pushed
the
updater-for-websockets
branch
from
3067170
to
961d332
Compare
basicer
force-pushed
the
updater-for-websockets
branch
from
961d332
to
eedb46f
Compare
tooomm
approved these changes
Feb 18, 2019
ebbit1q
reviewed
Feb 19, 2019
|
|
||
| for (int i = 0; i < size; i++) { | ||
| if (serv == getValue(QString("server%1").arg(i), "server", "server_details").toString()) { | ||
| setValue(port, QString("port%1").arg(i), "server", "server_details"); |
There was a problem hiding this comment.
I understand why this is copied but being inconsistent on one function having the port be optional while the other doesn't just irks me.
ctrlaltca
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Short roundup of the initial problem
What will change with this Pull Request?