Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xml v4 picURL. #3585

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Fix xml v4 picURL. #3585

merged 1 commit into from
Feb 21, 2019

Conversation

basicer
Copy link
Member

@basicer basicer commented Feb 21, 2019

Make v4 Cockatrice XML importer convert picURL to picurl to match v3 behavior and allow picURL images to load.

Short roundup of the initial problem

v4 XML files mishandle picURL

What will change with this Pull Request?

picURL will work.

… v3 behavior and allow picURL images to load.
Copy link
Contributor

@ctrlaltca ctrlaltca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you!

@ebbit1q
Copy link
Member

ebbit1q commented Feb 21, 2019

quickly add braces before zach sees it :)

@basicer basicer merged commit 9d27b36 into Cockatrice:master Feb 21, 2019
@ZeldaZach
Copy link
Member

Nice cha... wait, you forgot.... nvm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants