macOS: Fix qt5.12 scale issues and dark mode #3588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basicer
force-pushed
the
maybe-fix-Qt5.12-scale
branch
from
2aac296
to
04090e1
Compare
basicer
force-pushed
the
maybe-fix-Qt5.12-scale
branch
from
04090e1
to
2a4c291
Compare
basicer
force-pushed
the
maybe-fix-Qt5.12-scale
branch
from
e75bcd5
to
5d5c748
Compare
ZeldaZach
approved these changes
Feb 24, 2019
There was a problem hiding this comment.
I'm happy with this around 90% of the way. That's good enough imo to get it merged, but if you're interested to fix some corner cases:
- Deck editor color scheme is hard on the eyes for dark mode imo.
- Game play chat is hard to read and the active user is painful to look at.
ctrlaltca
approved these changes
Feb 24, 2019
tooomm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Short roundup of the initial problem
What will change with this Pull Request?
Screenshot