Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some dark mode colors. #3596

Merged
merged 2 commits into from
Mar 3, 2019
Merged

Fix some dark mode colors. #3596

merged 2 commits into from
Mar 3, 2019

Conversation

basicer
Copy link
Member

@basicer basicer commented Mar 2, 2019 •
edited

Short roundup of the initial problem

  • Help links look ugly in dark mode.
  • Chat looks ugly in dark mode.

What will change with this Pull Request?

  • They will look prettier

Screenshots

image

image

@basicer basicer changed the title Pick a link color that looks good in both light and dark mode Fix some dark mode colors. Mar 2, 2019
@ebbit1q
Copy link
Member

ebbit1q commented Mar 2, 2019

I notice there's some effect to light mode as well, the background got a little darker.
image

@ebbit1q
Copy link
Member

ebbit1q commented Mar 2, 2019

I consider the look of the chat widget acceptable now.
image

@ZeldaZach ZeldaZach merged commit a7f19f7 into Cockatrice:master Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@basicer @ebbit1q @ZeldaZach