try to use fabs instead of abs to see if flatpack cares #3638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tooomm
approved these changes
Mar 8, 2019
There was a problem hiding this comment.
Looking at flathub/io.github.Cockatrice.cockatrice#17 it seems to work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason builds on flatpack aren't working, this is a test if using fabs instead of abs is the issue.
To elaborate on this issue: abs(double) is not in c++11, it was added in c++17 and this is why we can still compile it.
Now fabs(double) is the exact same operation and available from c++11 onwards.