Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on card relation to inexistent card; fix #3637 #3640

Merged
merged 3 commits into from
Mar 10, 2019

Conversation

ctrlaltca
Copy link
Contributor

But that whole loop is a logic mess

Related Ticket(s)

@ctrlaltca ctrlaltca requested a review from ebbit1q March 9, 2019 08:54
Copy link
Member

@ebbit1q ebbit1q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the crash and everything is fine.
I tested with the xml from the ticket but cards with empty card relations still show up and do nothing:
image
We could consider removing them but it doesn't really matter.

@ebbit1q
Copy link
Member

ebbit1q commented Mar 9, 2019

Actually they do do something they show the card _____ from unhinged.

@ctrlaltca
Copy link
Contributor Author

Added a check if the related card exists before creating the menu

Copy link
Member

@ebbit1q ebbit1q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, now please run clangify so this can be merged.

@ctrlaltca ctrlaltca merged commit 52cc725 into Cockatrice:master Mar 10, 2019
@ctrlaltca ctrlaltca deleted the fix_3637 branch March 10, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants