Improve color selection for dark mode. #3654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change some SVGs from black to white if their background is too dark.
basicer
force-pushed
the
more-darkmode-improvements
branch
from
b1ace74
to
cee3694
Compare
ebbit1q
approved these changes
Mar 11, 2019
There was a problem hiding this comment.
Greatly improves how the player list looks like in dark mode!
Things I'd still like to see: improvements to the deck editor in dark mode, fixing of link colors in for example the cardinfo boxes, and allowing to switch to and from darkmode.
This is what it currently looks like if I force darkmode and then set it to light after:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Short roundup of the initial problem
What will change with this Pull Request?
Screenshots