Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cipt check for shock lands #3678

Merged
merged 3 commits into from
Apr 9, 2019
Merged

Conversation

skwerlman
Copy link
Contributor

Related Ticket(s)

Short roundup of the initial problem

Shock lands didn't come in tapped

What will change with this Pull Request?

  • Shock lands will come in tapped

The oracle text for shock lands has changed such that they no longer get `cipt`. This fixes that.
@ZeldaZach ZeldaZach marked this pull request as ready for review April 4, 2019 06:59
@skwerlman skwerlman marked this pull request as ready for review April 4, 2019 06:59
Copy link
Member

@ebbit1q ebbit1q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works just fine, the test could maybe be shortened to " it enters the battlefield tapped" but it only hits the shock lands either way so it doesn't matter at all.

@tooomm
Copy link
Member

tooomm commented Apr 5, 2019

A shorter text match could dodge further oracle updates wizards could come up with.

@skwerlman
Copy link
Contributor Author

updated to use the shorter check string

@ZeldaZach ZeldaZach merged commit d018070 into Cockatrice:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants