Oracle: skip cards with a star in the collectors' number #3706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can also skip |
ebbit1q
approved these changes
May 5, 2019
ebbit1q
added a commit
to ebbit1q/Cockatrice
that referenced
this pull request
Mar 1, 2020
this will correct Cockatrice#3706 and Cockatrice#3715 being a bit overzealous in removing cards and thus fix scheme cards being removed in entirety fix Cockatrice#3845 note that this causes a lot more cards to be added that are in promo sets, if these promo sets should prove to be problematic they should be disabled somehow as having them as an option is still nice.
ZeldaZach
pushed a commit
that referenced
this pull request
Mar 17, 2020
* ignore stars and promos but only sometimes this will correct #3706 and #3715 being a bit overzealous in removing cards and thus fix scheme cards being removed in entirety fix #3845 note that this causes a lot more cards to be added that are in promo sets, if these promo sets should prove to be problematic they should be disabled somehow as having them as an option is still nice. * remove debug lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Short roundup of the initial problem
WAR contains alternate printings of cards that are only available in a specific language.
These localized printings are currently being shown instead of the english ones.
All of these printings contains a star character ★ in their collectors' number.
What will change with this Pull Request?
Oracle will skip importing all hr cards with a ★ in the collectors' number.