Split buttons in the deck editor

[ctrlaltca]

Related Ticket(s)

• Fixes The deck minus/plus icons could perform a bit different more intelligently #3695

Short roundup of the initial problem

The deck editor buttons originally lived in the middle section, where tree filters are now placed.
Now that they have been moved to the left, their usage is counter-intuitive because:

• add card to deck / add card to sideboard target the card currently selected in the card database (left) pane
• increment / decrement / remove target the card currently selected in the deck (right) pane

What will change with this Pull Request?

The buttons targeting the deck have been moved in the deck pane.
Other minor style changes have been made to accomodate the change.

Screenshots

[ebbit1q]

I'm not sure if I like this change, what do others think?

[tooomm]

I like it a lot when playing with it in the client. 👍
Better than the old placement, logic wise.

Was there a particular reason why you changed the style @ctrlaltca ?
I think the old buttons (a bit bigger & icon only style) are better! That's the way we use them in all other places, too.
Is that due to the removing of deckEditToolBar QToolBar?

Here are the two in comparison:

old

new

Edit: If it helps in some way with the icons if there is no text in the same line, the hash could go at the very bottom below the deck list or directly above the separator and below the comment box.

[ctrlaltca]

Was there a particular reason why you changed the style @ctrlaltca ?
Is that due to the removing of deckEditToolBar QToolBar?

Exactly.
The extra space taken by the toolbar looked quite weird having only 2 buttons on it.
Anyway, i can revert to the old style if it looks better for you.

[tooomm]

The extra space taken by the toolbar looked quite weird having only 2 buttons on it.

Really? I think it looks much nicer: (I also like the little space between -/+ and X)

[ZeldaZach]

I'm very happy with this change and the new layout. Nice job!