Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc startup improvement #3740

Merged
merged 14 commits into from
Jun 3, 2019
Merged

Misc startup improvement #3740

merged 14 commits into from
Jun 3, 2019

Conversation

ctrlaltca
Copy link
Contributor

Related Ticket(s)

Short roundup of the initial problem

See #3738

What will change with this Pull Request?

The startup routine has been simplified, removing a lot of blocking steps when running a fresh installed or a just updated installation:

  • detect if this is a fresh installation or an update, and show a different welcome dialog informing the user to run oracle; eg. for new install:
    first
  • don't show tips window on first run: having a both a modal welcome dialog and a the tip window coming up at the same time is just too confusing; tip window will only show up on subsequent runs;
  • Tip window: ensure it's raised on top of the main window;
  • remove the "Update completed successfully. Cockatrice will now reload the card database." popup dialog; it's just redundant and you can't avoid it;
  • Remove the "The sets database has been saved successfully." popup when saving the sets dialog: it's redundant to inform the user of something that's expected to happen when confirming a dialog;
  • Remove the "The card database has been saved successfully to ..." popups in oracle. Instead, show the default path on the wizard page. Also, invert the "choose custom path" checkbox logic to make it more user-friendly:
    Schermata 2019-06-01 alle 16 42 13

I made some tests on fresh install / update / subsquent installs, but I'd really like some external testing on this. Thank you

Copy link
Member

@tooomm tooomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First quick check

oracle/src/oraclewizard.cpp Outdated Show resolved Hide resolved
oracle/src/oraclewizard.cpp Outdated Show resolved Hide resolved
@tooomm
Copy link
Member

tooomm commented Jun 2, 2019

Thanks for the path fixes, they are displayed correctly now. 👍

I have three further suggestions though:

  • It now simply closes automatically without a hint or comment after the token step. The user can't be sure if everything went well, something crashed or whatever. Maybe he realizes a reload, sometimes there might be a new set popup...
    But I think we can be more clear and helpful here. Especially for very new users.

    There could be a very last, new conclusion page in Oracle that gives you an overview of what happened so far, which steps succeeded, where files are stored and that the database update process is finished for example. Also giving the user the hint that Cockatrice will automatically reload, and that the user should restart the client if something isn't working as expected.

  • Can you reorder the phrasing with the paths a bit? I think that is more expressive:
    cards

  • The token import has two steps. Since it's only a simple file download, no parsing and processing it could all simply be on one single page: (token source selection + tokens imported)
    tokens

@ctrlaltca
Copy link
Contributor Author

ctrlaltca commented Jun 2, 2019

There could be a very last, new conclusion page in Oracle

Added.

Can you reorder the phrasing with the paths a bit?

Done

it could all simply be on one single page

Done for both tokens and spoilers.

tooomm and others added 5 commits June 2, 2019 18:20
Signed-off-by: Zach Halpern <ZaHalpern+github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

First startup is painful
3 participants