Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message log: remove all workarounds; fix #3553 #3760

Merged
merged 2 commits into from
Jul 8, 2019

Conversation

ctrlaltca
Copy link
Contributor

Related Ticket(s)

Short roundup of the initial problem

Please read #3759 first.

What will change with this Pull Request?

This is another attempt at fixing the problem. All the workarounds from messagelogwidget are removed, so that event logging is always in the correct order as it is expected.
Also, 2 minor fixes are included to avoid warning spam in the log.

@ctrlaltca
Copy link
Contributor Author

Please also have a look at #3759 before rewieving this: this PR and #3759 are two different attempts to fix the same problem.
This one changes a bit the behavior of the logger, but it eradicates the problem to ensure problems like #3553 won't happen again in the future.

@ctrlaltca ctrlaltca requested a review from basicer June 14, 2019 16:33
@tooomm tooomm requested a review from ZeldaZach June 30, 2019 14:16
Copy link
Member

@ZeldaZach ZeldaZach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works for me. The changes seem straight forward.

@ZeldaZach ZeldaZach merged commit f4adf79 into Cockatrice:master Jul 8, 2019
@ctrlaltca ctrlaltca deleted the messagelogwidget branch March 26, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite message log to not use events to guarantee order
3 participants