Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

properly capitalize set types like Duel Deck and From the Vault #3770

Merged
merged 3 commits into from
Jun 30, 2019
Merged

properly capitalize set types like Duel Deck and From the Vault #3770

merged 3 commits into from
Jun 30, 2019

Conversation

ebbit1q
Copy link
Member

@ebbit1q ebbit1q commented Jun 30, 2019 •
edited

Related Ticket

Screenshot

image

@tooomm
Copy link
Member

tooomm commented Jun 30, 2019

That's cool! Thanks for taking care.

Missing words in the list that don't get capitalized as well: of, in, and, with, but, or

@ebbit1q
Copy link
Member Author

ebbit1q commented Jun 30, 2019

I only included words that I thought might be included in the future, currently it's only needed for From the Vault

@ebbit1q
Copy link
Member Author

ebbit1q commented Jun 30, 2019

there, I included them

@tooomm
Copy link
Member

tooomm commented Jun 30, 2019

If it doesn't hurt to have them. 👍
But you are right that the possible list of set_types shouldn't change to much and often...

tooomm
tooomm approved these changes Jun 30, 2019
View reviewed changes
Copy link
Member

@tooomm tooomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macOS builds are having a proplem at Travis currently

@ZeldaZach ZeldaZach merged commit f10f9ad into Cockatrice:master Jun 30, 2019
@tooomm tooomm mentioned this pull request Jul 1, 2019
Merged
@ebbit1q ebbit1q deleted the captype branch July 3, 2019 10:54
@tooomm tooomm mentioned this pull request Jul 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tooomm tooomm tooomm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

set types are not displayed perfectly
3 participants
@ebbit1q @tooomm @ZeldaZach