Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add homebrew cache to cache #3776

Merged
merged 7 commits into from
Jul 11, 2019
Merged

add homebrew cache to cache #3776

merged 7 commits into from
Jul 11, 2019

Conversation

ebbit1q
Copy link
Member

@ebbit1q ebbit1q commented Jul 8, 2019

We'll build this a few times

Related Ticket(s)

tooomm
tooomm approved these changes Jul 8, 2019
View reviewed changes
Copy link
Member

@tooomm tooomm left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why the CI run isn't triggered.

But comparing the changes to the linked article, it looks right. 👍
It's just a secret how big the effect is.

Note: This also includes #3771

@ebbit1q
Copy link
Member Author

ebbit1q commented Jul 8, 2019

I'm triggered by the ci not being triggered

@ebbit1q
Copy link
Member Author

ebbit1q commented Jul 8, 2019

eeek, it's using 5.13

@ebbit1q
Copy link
Member Author

ebbit1q commented Jul 8, 2019

Acceptable build time, under 10 mins.

@tooomm
Copy link
Member

tooomm commented Jul 9, 2019

eeek, it's using 5.13

No ~qt-lts on homebrew. Always only the newest... 😢
It also silently switched on our master branch already.

But nice improvement here.

@ZeldaZach ZeldaZach merged commit 5139039 into Cockatrice:master Jul 11, 2019
@ebbit1q ebbit1q deleted the brewcache branch July 11, 2019 13:21
@tooomm tooomm mentioned this pull request Jul 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tooomm tooomm tooomm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cache homebrew in travis
3 participants
@ebbit1q @tooomm @ZeldaZach