Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close all player-associated zoneviews when he quits; fix #3799 #3800

Merged
merged 2 commits into from
Aug 28, 2019

Conversation

ctrlaltca
Copy link
Contributor

Related Ticket(s)

Short roundup of the initial problem

When a player quits, all the related resources gets removed from memory (cards, zones, etc..).
If a zoneview (eg. hand view of that player) is open, it starts to refer to the already deleted player.
Once you try to close the view, it crashes.

What will change with this Pull Request?

  • All zoneviews associated to a specific player are closed automatically when the player is deleted from the game

@ZeldaZach ZeldaZach merged commit 3b98eb7 into Cockatrice:master Aug 28, 2019
@ctrlaltca ctrlaltca deleted the fix_3799 branch March 26, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation Fault when closing hand popup in local game replay
2 participants