Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip all duplicate promos instead of just stars #3965

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

ebbit1q
Copy link
Member

@ebbit1q ebbit1q commented Apr 22, 2020

fix #3964
see #3904 which did this for all unique numbers, now this has been replaced with unique names because that's what we care about anyway and cards that have the isPromo field are added to it as well.

@ebbit1q
Copy link
Member Author

ebbit1q commented Apr 22, 2020

Note this removes cards like godzilla entirely, so people that want these cards will have to use custom images instead. An alternative solution to this would be to automatically generate an additional set to hold these duplicate cards but the custom image folder is a better system for these people anyways as they only want some of these promos and not all of them.

@ebbit1q
Copy link
Member Author

ebbit1q commented Apr 22, 2020

https://travis-ci.org/github/Cockatrice/Cockatrice/builds/678126222 ci completed but it's not reflected here :/

@ZeldaZach
Copy link
Member

I'd like to see the cards split up on Cockatrice's end into separate internal sets. Removing godzillas entirely is a bleh thing. Will still merge if it addresses issues, but I'd like that fixed

@ebbit1q
Copy link
Member Author

ebbit1q commented Apr 22, 2020

do you want godzilla to be an entirely separate card instead of an alt art for its original card?

@ZeldaZach
Copy link
Member

This goes along w/ the plan of changing how we load in specific cards. Should have a way for people to specify their art, even if local only. Maybe with a dropdown menu per-card saving in the cache?

@ebbit1q
Copy link
Member Author

ebbit1q commented Apr 22, 2020

Apparently there is no original zilortha card so godzilla doesn't get removed, this pr only removes promos if they are duplicates of another card in the same set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ikoria] Wrong picture for many cards
2 participants