Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent the checkboxes' labels from being clipped in settings #3968

Merged
merged 1 commit into from
Apr 24, 2020

Conversation

Olxinos
Copy link
Contributor

@Olxinos Olxinos commented Apr 24, 2020

Related Ticket(s)

Fixes #3950

Short roundup of the initial problem

On OSX, the checkboxes' labels could sometimes be cut short when resizing the settings' window (c.f. #3950 for screenshots). The problem didn't seem to appear on Windows due to smaller font sizes.

What will change with this Pull Request?

The checkboxes now span the two columns of the grid layout rather than a single one, allowing them to extend beneath the comboboxes on the right. This also makes the settings' window slightly less wide.

Copy link
Contributor

@ctrlaltca ctrlaltca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you!

@ctrlaltca ctrlaltca merged commit 46fe0cd into Cockatrice:master Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings menu clipping on Mac
2 participants