Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure no //es are added to maintypes #4017

Merged
merged 2 commits into from
Jun 2, 2020

Conversation

ebbit1q
Copy link
Member

@ebbit1q ebbit1q commented Jun 1, 2020

instead of only avoiding this on adventures they should just be avoided
on any card so the maintype instant // sorcery isn't created for example,
the normal typeline isn't affected by this

fixes #3972

instead of only avoiding this on adventures they should just be avoided
on any card so the maintype instant // sorcery isn't created for example,
the normal typeline isn't affected by this

fixes Cockatrice#3972
Copy link
Member

@tooomm tooomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start // Finish correctly goes to the (gy from) stack now.

Edit: 🙈

@ebbit1q
Copy link
Member Author

ebbit1q commented Jun 2, 2020

All spells go to the stack, this spell did that too, this change means that it now goes to the graveyard after.

@ZeldaZach ZeldaZach merged commit 53c6440 into Cockatrice:master Jun 2, 2020
@ebbit1q ebbit1q deleted the splitcards_maintype branch June 3, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double click instants/sorceries from stack to graveyard
3 participants