Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

travis: update macos 10.15 images #4059

Merged
merged 4 commits into from
Aug 6, 2020
Merged

travis: update macos 10.15 images #4059

merged 4 commits into from
Aug 6, 2020

Conversation

tooomm
Copy link
Member

@tooomm tooomm commented Aug 3, 2020 •
edited

What will change with this Pull Request?

  • use most recent (non-beta) Catalina (10.15) image available on travis
  • high sierra is still on the latest, no changes needed

@ctrlaltca
Copy link
Contributor

You could even switch to catalina, it should support all the macs that mojave supports.

@tooomm
Copy link
Member Author

tooomm commented Aug 3, 2020 •
edited

Will check, expected it to cut older macs off.

Edit: macOS 10.15 only leaves some old Mac Pro's from 2010/2012 behind. Save to update probably.
Went with the normal Xcode 12, not the new "Universal" one. Universal supports Apples upcoming own chips + Intel chips - something for later. Xcode 12 is still in beta, travis docs doesn't mention that. Using Xcode 11.6 now.

Catalina finishes in under 40% of the time compared to High Sierra due to the more recent homebrew.

@tooomm tooomm changed the title travis: update macos 10.14 images travis: update macos 10.15 images Aug 3, 2020
@ZeldaZach ZeldaZach merged commit 80f613a into master Aug 6, 2020
@ZeldaZach ZeldaZach deleted the tooomm-patch-3 branch August 6, 2020 14:43
@ZeldaZach
Copy link
Member

I'm fine with the bump, as we don't lose anything

@ebbit1q
Copy link
Member

ebbit1q commented Aug 12, 2020

Which versions of macos are supported by this build?

@tooomm
Copy link
Member Author

tooomm commented Aug 12, 2020

With this PR we build on

So for releases, the deployed dmg is unchanged and still supports 10.13+ (should still run on 10.15, but without Dark Mode support).
The zipped dmg is now 10.15+ (instead 10.14+).

@ebbit1q
Copy link
Member

ebbit1q commented Aug 12, 2020 •
edited

So we dropped dark mode support from 10.14? (important to put in the release notes)

@ZeldaZach
Copy link
Member

All machines that can run 10.14 can also run 10.15, so they'd just have to upgrade

@ebbit1q
Copy link
Member

ebbit1q commented Aug 12, 2020

Yes, but they should know that they need to upgrade as well.

longagofaraway pushed a commit to longagofaraway/Cockatrice that referenced this pull request Aug 14, 2020
@olegshtch @tooomm
@LeeTranMN @ebbit1q @awlangham
Update upstream (#2)
2ab2653 
* move db udpate (Cockatrice#4015)

* Remove gitlab config (Cockatrice#4037)

* revert Cockatrice#2345

* remove gitlab yml

* fix message when moving cards to bottom of library (Cockatrice#4006)

* Change method of opening directories to be the same for all oses, including linux (Cockatrice#4046)

* add opening directory in file browser to linux

this uses QDesktopServices to open the url "file://[location]"
by default this is
"file://$HOME/.local/share/Cockatrice/Cockatrice/pics/CUSTOM"

any distro that has a file browser should have an accompanying mime type
specifying the file handler for the file:// protocol using the
inode/directory mime type

see https://specifications.freedesktop.org/shared-mime-info-spec/shared-mime-info-spec-latest.html

if a user were to have removed their mime database this will not work and
it will fail with nothing but a log message, this would be rare and not
worth checking in my opinion

* make opening directories the same for all oses

* sort headers

* Made user information window resizable (Cockatrice#4009)

* Added horizontal layout and stretch for player icon (Cockatrice#4052)

* Fix unresolved symbols when link tests to system libgtest-dev (Cockatrice#4055)

* Enable parallel compilation. (Cockatrice#4057)

* travis: update macos 10.15 images (Cockatrice#4059)

* Fix release tests (Cockatrice#4063)

Co-authored-by: tooomm <tooomm@users.noreply.github.com>
Co-authored-by: Lee Tran <54418451+LeeTranMN@users.noreply.github.com>
Co-authored-by: ebbit1q <ebbit1q@gmail.com>
Co-authored-by: awlangham <awlangham@gmail.com>
@ebbit1q ebbit1q mentioned this pull request Sep 8, 2020
Merged
@tooomm tooomm mentioned this pull request Oct 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tooomm @ctrlaltca @ZeldaZach @ebbit1q