Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resizing for game filter dialog #4149

Merged
merged 2 commits into from
Oct 30, 2020
Merged

Fix resizing for game filter dialog #4149

merged 2 commits into from
Oct 30, 2020

Conversation

tooomm
Copy link
Member

@tooomm tooomm commented Oct 28, 2020 •
edited
Loading

Related Ticket(s)

Short roundup of the initial problem

Dialog behaved weird on resizing.

What will change with this Pull Request?

  • Added a stretch element to the right "column" as well. Game types or spectator options will not stretch any longer
  • As there is no reason in making the dialog longer, it's now always the suggested vertical size (same as the Create game dialog)

Screenshots

  • before:
    image

  • after:
    with long list of game types
    stretchfixed

    with short list of games types
    stretchfix2

knitknit
knitknit approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@knitknit knitknit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@ZeldaZach ZeldaZach merged commit ef78fdf into master Oct 30, 2020
@ZeldaZach ZeldaZach deleted the tooomm-game_filter_dialog branch October 30, 2020 00:21
@tooomm tooomm mentioned this pull request Feb 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knitknit knitknit knitknit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resizing filter widget behaves weirdly
3 participants
@tooomm @knitknit @ZeldaZach