don't sort split card halves alphabetically #4244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes Cockatrice#4241 introduces new issue: aftermath cards are now switched upside down
ZeldaZach
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split cards are sorted alphabetically before merging, resulting in the lower value half being the top/left/first side.
This affects aftermath, adventure and normal split cards.
examples:
giant killer // chop down
failure // comply
smelt // herd // saw
Instead the order in which they appear in mtgjson is used, which happily coincides with the order in which they should be except for adventures which we reverse in order.
fixes #4241