Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only invalidate undoDrawList up to moved card #4280

Merged
merged 1 commit into from
Mar 13, 2021

Conversation

ebbit1q
Copy link
Member

@ebbit1q ebbit1q commented Mar 13, 2021

Related Ticket(s)

Short roundup of the initial problem

#4152 introduced the ability to still undo card draws even after playing other cards
this would introduce inconsistency where you could draw cards and simply continue playing without touching the drawn cards and suddenly undraw it, but not if you touched any of these cards.

What will change with this Pull Request?

  • behavior is now consistent, all cards drawn after the most recently removed card are now possible to undo
    • this means you can still undo a draw if you drew one card too many and continued playing without "compromising" the board state
  • another option was to allow the card before it to be "undrawn" until the hand is empty
  • the simplest would be to always clear the list if a card leaves it, this was discussed in Allow undo draw if card was moved within hand #4152

@ZeldaZach ZeldaZach merged commit 1811f73 into Cockatrice:master Mar 13, 2021
@ebbit1q ebbit1q deleted the permit_undo_draws branch March 13, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants