Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create game as spectator #4281

Merged
merged 6 commits into from
Mar 13, 2021
Merged

Conversation

ebbit1q
Copy link
Member

@ebbit1q ebbit1q commented Mar 13, 2021

Short roundup of the initial problem

This seems to be a useful feature for tournament organisers, allowing to create a game for participants

What will change with this Pull Request?

  • allow creation of games as spectator
  • add settings and menu items for this
  • allow elevated users to create games as spectator in judge mode without limit
  • allow setting the limit to 0 effectively disallowing other users to create games
  • change the function for automatically closing inactive games to check for the presence of an active host player instead of counting players, this prevents games being closed automatically while the host is spectating
  • allow users to see 0 player games in the games list
  • disallow the transfer of the host status to spectators, this caused strange issues where the host status wasn't properly signaled, this issue is also present on master but is harmless, I don't think users rejoining a game as spectator should be given host status

Screenshots

image

allow setting the amount of games per user to none
remove limit on amount of games when creating a game as judge as
spectator
this check didn't really do anything, deleted games are removed before
it would be reached
this seems to cause a bug, also present on master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants