-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add more info to dialogs #4293
add more info to dialogs #4293
Conversation
tr("Only cards in enabled sets will appear in the card list of the deck editor") + "<br><br>" + | ||
"<b>" + tr("Card Art") + ":</b> " + tr("Image priority is decided in the following order") + | ||
"<ol><li>" + tr("CUSTOM Folder") + | ||
labNotes->setText(tr("Use ctrl+a to select all sets in the view.") + "<br><b>" + tr("Deck Editor") + ":</b> " + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
labNotes->setText(tr("Use ctrl+a to select all sets in the view.") + "<br><b>" + tr("Deck Editor") + ":</b> " + | |
labNotes->setText(tr("Use CTRL+A to select all sets in the view.") + "<br><b>" + tr("Deck Editor") + ":</b> " + |
Regarding all hintsGrid:
Don't you think the extra line breaks were useful?
Because of how lists are displayed you now have two blocks, but the second block being bullet points of the last element of the first block. The connection and context is not as clear now as seen in your screen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to make it smaller, it's taking up a lot of space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, sure. Both not ideal. :)
in order to make the list smaller I stopped disabled sets from being used for image art, this resulted in a >1% performance increase as shown with the added timer |
adds descriptive strings to the register, password reset request, password reset challenge request, password reset token dialogs adds tip to set manager to use ctrl a to select all sets change sizes in set manager moves default server info to settings instead of having it hardcoded in each dialog
I removed a few needless entries to the server dialog settings, among which a password entry that saves the password you used last in the register or recover dialog, whether you want it or not............ |
adds descriptive strings to the register, password reset request,
password reset challenge request, password reset token dialogs
adds tip to set manager to use ctrl a to select all sets
change sizes in set manager
moves default server info to settings instead of having it hardcoded in
each dialog
default size of sets manager is now this