Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check multiple file extension inclusions for custom cards #4308

Merged
merged 1 commit into from
Apr 16, 2021
Merged

check multiple file extension inclusions for custom cards #4308

merged 1 commit into from
Apr 16, 2021

Conversation

ebbit1q
Copy link
Member

@ebbit1q ebbit1q commented Apr 11, 2021

Related Ticket(s)

Short roundup of the initial problem

. in cardname causes it to not work for custom cards

What will change with this Pull Request?

  • both full fileName and completeBaseName are now checked as well in order to catch more amounts of dots in filenames

@ZeldaZach ZeldaZach merged commit 5969656 into Cockatrice:master Apr 16, 2021
@ebbit1q ebbit1q deleted the fix_4307 branch May 7, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeldaZach ZeldaZach ZeldaZach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

period . sign in card name causes it to be unable to customise it
2 participants
@ebbit1q @ZeldaZach